[stable27] fix(ExternalSharing): Handle template shares from external sources#46279
Merged
AndyScherzinger merged 3 commits intostable27from Jul 12, 2024
Merged
[stable27] fix(ExternalSharing): Handle template shares from external sources#46279AndyScherzinger merged 3 commits intostable27from
AndyScherzinger merged 3 commits intostable27from
Conversation
a604483 to
5962472
Compare
5962472 to
07d9ff8
Compare
nfebe
approved these changes
Jul 3, 2024
artonge
approved these changes
Jul 3, 2024
07d9ff8 to
8aea203
Compare
Member
|
/compile / |
4927934 to
3e1384c
Compare
Member
|
/compile / |
bce6654 to
1e87d7c
Compare
Contributor
|
/compile / |
The new sharing flow requires or implies that users should edit share before creating. External sources should not created the share IF we would upon sharing details tab on first request. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
The new sharing flow since NC27 requires that users open the sharing details tab and customize their share before creating it. In #39472 the work of `addShare` was handed down to `openSharingDetails` that opens the sharing details tab for the user to customize and manually creat their share. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1d3510e to
8517c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #46068
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.