feat: add commands for exporting current and expected database schema#46194
Merged
icewind1991 merged 1 commit intomasterfrom Jul 2, 2024
Merged
feat: add commands for exporting current and expected database schema#46194icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
come-nc
reviewed
Jul 1, 2024
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Looks good apart from deprecated method call.
6c467c3 to
0681559
Compare
0681559 to
2a1c260
Compare
2a1c260 to
0120a0f
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
0120a0f to
4f01486
Compare
come-nc
approved these changes
Jul 2, 2024
| $output->writeln($schema->toSql($this->connection->getDatabasePlatform())); | ||
| } else { | ||
| $encoder = new SchemaEncoder(); | ||
| $this->writeArrayInOutputFormat($input, $output, $encoder->encodeSchema($schema, $this->connection->getDatabasePlatform())); |
Contributor
There was a problem hiding this comment.
We should add support for iterables in there to some day be able to output while computing when not using json output.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be useful when investigating database related issue.