debt(encryption): Migrate app.php to Application.php#46136
Merged
Conversation
6f19303 to
c89087d
Compare
Contributor
Author
|
Seems to work in the current state. |
come-nc
reviewed
Jun 27, 2024
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Two nitpicks, otherwise, awesome job, one less app.php 👍
c89087d to
333ca35
Compare
kyteinsky
approved these changes
Jun 28, 2024
Signed-off-by: Louis Chemineau <louis@chmn.me>
333ca35 to
39fd19f
Compare
This was referenced Jul 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to prevent exceptions generated from
app.phpto disable the encryption app.