chore: Enable ESLint for apps and fix all errors#46082
Merged
Conversation
st3iny
approved these changes
Jun 25, 2024
Member
st3iny
left a comment
There was a problem hiding this comment.
LGTM! There are npm build changes though.
st3iny
reviewed
Jun 25, 2024
Member
|
Nice find 🙈 |
ShGKme
approved these changes
Jun 25, 2024
Contributor
ShGKme
left a comment
There was a problem hiding this comment.
Thanks!
Checked all the changes, looks good.
I expected much more changes 👀
The only thing I'm working about is removing the import. Having a file it is not easily possible to say if removing this line is safe. And strictly, each file with dialogs must have dialog styles.
import '@nextcloud/password-confirmation/dist/style.css'
Comment on lines
+16
to
+17
| "lint": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"apps/$appdir \"; fi; done) core --no-error-on-unmatched-pattern", | ||
| "lint:fix": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"apps/$appdir \"; fi; done) core --no-error-on-unmatched-pattern --fix", |
Contributor
There was a problem hiding this comment.
It's been worrying me for a year 🙈
ChristophWurst
approved these changes
Jun 25, 2024
b7cdf76 to
df92bea
Compare
Contributor
Author
|
/compile |
b816e37 to
91f4df6
Compare
Contributor
Author
|
Current blocker: |
91f4df6 to
e626183
Compare
e626183 to
29c6ab3
Compare
Member
|
Can we do that just after branch off 31 please 🙏 |
29c6ab3 to
ccb97bd
Compare
Nevertheless this causes a huge amount of new warnings. Previously the shell script for directories to lint was wrong it was generating all app names to lint, but was missing the `apps/` prefix. Causing only `core` to be linted. Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
ccb97bd to
b0f6686
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nevertheless this causes a huge amount of new warnings. Previously the shell script for directories to lint was wrong it was generating all app names to lint, but was missing the
apps/prefix. Causing onlycoreto be linted.Checklist