refactor(cron): Use IAppConfig for cron settings and migrate ajax cron away from jQuery#46009
Merged
refactor(cron): Use IAppConfig for cron settings and migrate ajax cron away from jQuery#46009
IAppConfig for cron settings and migrate ajax cron away from jQuery#46009Conversation
87845ac to
9120e21
Compare
Contributor
|
Cool, Thank you 👍 |
come-nc
reviewed
Jun 20, 2024
Contributor
come-nc
left a comment
There was a problem hiding this comment.
You need to adapt AccessFactory to Access constructor changes.
9120e21 to
e5d2c4e
Compare
icewind1991
approved these changes
Jun 21, 2024
e5d2c4e to
e5464d7
Compare
Contributor
Author
|
/compile |
This comment was marked as resolved.
This comment was marked as resolved.
b225d62 to
18b90be
Compare
Member
|
unit tests are still failing |
18b90be to
04f9744
Compare
Contributor
6 tasks
kesselb
reviewed
Jun 28, 2024
kesselb
reviewed
Jun 28, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
04f9744 to
25361b0
Compare
Contributor
|
I think it will be easier to manually backport the changes to the base command for 29 and thus removed the backport request. |
kesselb
approved these changes
Jun 28, 2024
Contributor
kesselb
left a comment
There was a problem hiding this comment.
- Login
- occ commands
- core-ajax-cron.js only loaded for ajax
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
25361b0 to
4f79076
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This contains two refactor commits for background job / cron settings:
IAppConfigfor setting of cron type (ajax, web-cron, cron)Checklist