Feat: add new clickable area variables#45818
Merged
marcoambrosini merged 2 commits intomasterfrom Jun 14, 2024
Merged
Conversation
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
7 tasks
artonge
approved these changes
Jun 12, 2024
susnux
approved these changes
Jun 12, 2024
Contributor
susnux
left a comment
There was a problem hiding this comment.
Maybe keep the large clickable area at 44px, but either way ok for me :)
susnux
reviewed
Jun 12, 2024
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Marco <marcoambrosini@proton.me>
AndyScherzinger
approved these changes
Jun 12, 2024
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Should clickable-area-large not be 44px, so we don't make elements even bigger?
Member
Author
|
@jancborchardt sorry I missed your comment, I thought it'd be good to boost it a bit since it would be only one button per app basically. This would be also in line with what google and dropbox do. But we can see how it looks and dial it back before release in case it's too much |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new variables for clickable areas and reduces size of
--default-clickable-areaPart of #45657