Replace icons with latest `Material Symbol` versions #45755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AndyScherzinger merged 6 commits into master from chore/noid/spdx-batch15

Jun 10, 2024

Member

AndyScherzinger commented Jun 10, 2024 •

edited

Loading

Resolves: up-to-date icons (style) and SPDX info for them
Resolves: Substitute icons by Material Design ones? #27735

Summary

TODO

visual review from designers
optimize svg files
compile icon.css
review and merge

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

AndyScherzinger added design 2. developing labels

AndyScherzinger added this to the Nextcloud 30 milestone

Member Author

AndyScherzinger commented Jun 10, 2024

https://github.com/nextcloud/server/pull/45755/files#diff-400d26bc489aa2e67324c88e3930cffa372a501af3be65f3cd4867689f4aef1c has been changed in the former PR and is now reverted back to the group icon, for consistency

AndyScherzinger requested a review from jancborchardt

June 10, 2024 11:48

jancborchardt reviewed

View reviewed changes

core/img/actions/address.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/clippy.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/comment.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/delete.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/details.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/download.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/fullscreen.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/info-white.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/logout.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/rename.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/share.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/unshare.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/upload.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/video-off.svg Show resolved Hide resolved

jancborchardt reviewed

View reviewed changes

core/img/actions/view-download.svg Show resolved Hide resolved

jancborchardt requested changes

View reviewed changes

Member

jancborchardt left a comment

See review comments inline, other icons look good! :)

AndyScherzinger force-pushed the chore/noid/spdx-batch15 branch 5 times, most recently from 501dc57 to 8e91908 Compare

June 10, 2024 15:53

AndyScherzinger added 4 commits

June 10, 2024 18:14


          chore: Replace icons with latest Material Design versions

e6d6853

Signed-off-by: Andy Scherzinger <[email protected]>


          chore: Update license infos

74aa004

Signed-off-by: Andy Scherzinger <[email protected]>


          chore: update mastodon icon with original resource

38202c0

Signed-off-by: Andy Scherzinger <[email protected]>


          chore: Add further media resource license info items

83e85f4

Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger force-pushed the chore/noid/spdx-batch15 branch from a773631 to 83e85f4 Compare

June 10, 2024 16:14

Member Author

AndyScherzinger commented Jun 10, 2024

/compile /

AndyScherzinger added 3. to review and removed 2. developing labels

AndyScherzinger requested review from susnux and szaimen

June 10, 2024 16:15

AndyScherzinger added the technical debt label

AndyScherzinger requested a review from jancborchardt

June 10, 2024 16:17

jancborchardt approved these changes

View reviewed changes

AndyScherzinger changed the title ~~Replace icons with latest Material Design versions~~ Replace icons with latest Material Symbol versions

AndyScherzinger changed the title ~~Replace icons with latest Material Symbol versions~~ Replace icons with latest *Material Symbol* versions

AndyScherzinger changed the title ~~Replace icons with latest *Material Symbol* versions~~ Replace icons with latest Material Symbol versions

nextcloud-command and others added 2 commits

June 10, 2024 16:45


          chore(assets): Recompile assets

2cd4449

Signed-off-by: nextcloud-command <[email protected]>


          chore: Update comments app icon

cca4978

Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger force-pushed the chore/noid/spdx-batch15 branch from 423e6a8 to cca4978 Compare

June 10, 2024 16:50

miaulalala approved these changes

View reviewed changes

AndyScherzinger merged commit 44ed10d into master

AndyScherzinger deleted the chore/noid/spdx-batch15 branch

June 10, 2024 17:20

blizzz mentioned this pull request

30.0.0 beta 1 #46713

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review design technical debt