Merged
Conversation
251a504 to
fe67ade
Compare
fe67ade to
5dddfef
Compare
3854a20 to
5b84290
Compare
5b84290 to
26dc8c6
Compare
Member
|
/compile / |
029f787 to
63faa65
Compare
Member
|
Cypress error:
Related or flaky? |
Contributor
sounds flaky |
Member
There is a similar failing test with Selenium 🤔 https://drone.nextcloud.com/nextcloud/server/55895/57/4 |
63faa65 to
b563edd
Compare
e61077c to
0feafef
Compare
Member
|
@susnux * │ ✖ Navigation.cy.ts 00:55 9 5 4 - - │* keeps failing
|
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
0feafef to
10b104f
Compare
Contributor
|
Seems like the module export changed, so for mocking in the test we need to default import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit report
This audit fix resolves 21 of the total 30 vulnerabilities found in your project.
Updated dependencies
Fixed vulnerabilities
@adobe/css-tools #
node_modules/@adobe/css-tools@babel/traverse #
node_modules/@babel/traverse@cypress/request #
node_modules/@cypress/request@jimp/core #
node_modules/@jimp/core@jimp/custom #
node_modules/@jimp/custom@nextcloud/cypress #
node_modules/@nextcloud/cypressbrowserify-sign #
dsaVerifyleads to a signature forgery attacknode_modules/browserify-signcypress #
node_modules/cypressejs #
node_modules/ejsexpress #
node_modules/expressfollow-redirects #
node_modules/follow-redirectsload-bmfont #
node_modules/load-bmfontnextcloud-vue-collections #
node_modules/nextcloud-vue-collectionsnode-vibrant #
node_modules/node-vibrantparse-bmfont-xml #
node_modules/parse-bmfont-xmlphin #
node_modules/phinselect2 #
node_modules/select2tar #
node_modules/tarwait-on #
node_modules/wait-onwebpack-dev-middleware #
node_modules/webpack-dev-middlewarexml2js #
node_modules/xml2js