fix: use different file name for generated dark avatars

[kesselb]

• Resolves: noid

Summary

I wondered, while debugging an issue, about many write requests for my generated user avatar.

Likely the condition $darkTheme && !$generated should be $darkTheme && $generated to match the implementation in UserAvatar.getFile.

If you want to reproduce, make sure to NOT have a default generated avatar.

Super edgy, no backports needed.

server/lib/private/Avatar/UserAvatar.php

Lines 172 to 184 in ae4a6e8

	if ($darkTheme && !$generated) {
	if ($this->folder->fileExists('avatar-dark.jpg')) {
	return 'jpg';
	} elseif ($this->folder->fileExists('avatar-dark.png')) {
	return 'png';
	}
	}
	if ($this->folder->fileExists('avatar.jpg')) {
	return 'jpg';
	} elseif ($this->folder->fileExists('avatar.png')) {
	return 'png';
	}
	throw new NotFoundException;

Screencast.from.2024-05-26.17-13-51.webm

TODO

• CI
• Review

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[st3iny]

Good catch! Didn't test but the code looks good.