fix: Only list remnants as disabled if option is enabled#45347
Merged
Conversation
blizzz
approved these changes
May 16, 2024
artonge
approved these changes
May 16, 2024
Pytal
approved these changes
May 16, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
5a154cb to
e14620c
Compare
Contributor
Author
|
@Pytal We should backport to 29 and 28, right? |
Member
|
Not 100% sure here, will let you decide @come-nc |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In 28 a new config option was added to consider remnants as disabled users.
But they were appearing in the list of disabled users even if the new option was not used, which can be confusing.
With this PR remnants are back at being ghosts by default and will only appear in disabled user list if the option is checked.
One problem is that the option is only checked on the first LDAP configuration and applied to all of them regarding to listing disabled users, because there is no efficient way to do otherwise (all remnants are in the same place). We already have this kind of trick for other things and expect that LDAP configurations are not too different from one another on the same server usually.
Checklist