feat: Split display name and username columns

[Pytal]

Summary

• Split the columns in preparation for making the table sortable and adding header sort buttons

Before	After

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

Makes sense for me, lets wait for designers.

[joshtrichards]

Might be some intersection with #34178 (to avoid future code debt) though I didn't really follow where that stands since it's merged and the menu entry to get to Accounts is still labeled as Users so dunno.

In any case, seems header Username -> Login I think?

[Pytal]

Might be some intersection with #34178 (to avoid future code debt) though I didn't really follow where that stands since it's merged and the menu entry to get to Accounts is still labeled as Users so dunno.

I think this was intentional @skjnldsv ?

In any case, seems header Username -> Login I think?

On the login page it is also "username" so I will keep it the same

[jancborchardt]

Seems good!

Agree with @joshtrichards that Username should be "Account name" (same on the login screen). But it’s something for a separate pull request. :)

[jancborchardt]

Also question @Pytal – isn’t the sorting we add by "Last login" only? (And display name which is the default.) Or are we just going to make everything sortable?

[Pytal]

Agree with @joshtrichards that Username should be "Account name" (same on the login screen). But it’s something for a separate pull request. :)

Sure, can do in a followup :)

Also question @Pytal – isn’t the sorting we add by "Last login" only? (And display name which is the default.) Or are we just going to make everything sortable?

Will just be displayname, userId, and last login for now as that is what has been implemented on the backend, not sure about others as it may be complicated

[Pytal]

/compile amend /