feat: add option to disable scanner transactions#45172
Merged
icewind1991 merged 1 commit intomasterfrom Jun 13, 2024
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
artonge
approved these changes
Jun 13, 2024
nfebe
approved these changes
Jun 13, 2024
Contributor
nfebe
left a comment
There was a problem hiding this comment.
Add filescanner_no_transactions to sample config?
Member
Author
Given the uncertainty around the effects I think it's better not to advertise this at the moment. Instead I would rather change the behavior for everyone once we've done more testing around this. |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
|
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/45172/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f5219a19
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45172/stable27Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
Member
Author
|
stable27: #45681 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not a 100% sure about the full impact of disabling this regarding performance/deadlocks/etc. But having a config flag for this makes it easier to figure out the impact.