feat: include file id in audit logs#44871
Conversation
|
Sorry, don't feel confident enough to review this |
| } catch (InvalidPathException|NotFoundException $e) { | ||
| return; |
There was a problem hiding this comment.
Should still log something, maybe even on error level, so that this is not missed.
There was a problem hiding this comment.
@come-nc logging the exception message as error in log file. I tried to delete a file that is already deleted from oc_filecache and also removed from data/admin/files/log.txt. I get a message in the UI saying "Delete file" action failed but i did not find it getting logged as a error message
|
Please also fix commit names, should not all start with |
|
|
||
| /** | ||
| * Log a error message with a log level of error | ||
| * @param string $text | ||
| */ | ||
| public function error(string $text): void { | ||
| $this->logger->error($text, ['app' => 'admin_audit']); | ||
| } |
There was a problem hiding this comment.
Please remove this method, it makes thing unnecessiraly convoluted.
Inject the loggen in the child class if possible, use \OCP\Server::get if not.
6ed0835 to
977bf8e
Compare
bc3e830 to
710f11d
Compare
come-nc
left a comment
There was a problem hiding this comment.
Please fix the commit description:
710f11d to
7b0b54f
Compare
Signed-off-by: yemkareems <yemkareems@gmail.com>
7b0b54f to
4d22880
Compare
Summary
nc.logs.txt
Checklist