chore: Fix update-psalm-baseline to use correct php version depending on branch#44861
Merged
nickvergessen merged 1 commit intomasterfrom Apr 22, 2024
Merged
Conversation
Member
|
Should add it like in apps, e.g. https://github.com/nextcloud/spreed/blob/main/psalm.xml#L8 |
1babaa7 to
f6a443f
Compare
Needs to be adapted on each branch to reflect the used PHP version and help with baseline updating. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
f6a443f to
9092dcf
Compare
Contributor
Author
Ok, trying this way then, putting 8.1 in master and will change to 8.0 in the backports. |
Contributor
Author
|
/backport to stable29 |
provokateurin
approved these changes
Apr 22, 2024
nickvergessen
approved these changes
Apr 22, 2024
Member
|
Backporting is not going to work, 29 and lower need 8.0 at least. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workflow currently always use 8.1, it should use the same PHP version as the psalm run on the target branch.Adding the PHP version to psalm.xml so that the update-baseline workflow is aware of it. Backports will need to adapt the PHP version to the one used in their psalm workflow (the lowest PHP version supported usually).
Checklist