Check whether we can json decode the translations#4485
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
| "Save" : "保存", | ||
| "Allowed characters {count} of {max}" : "当前字数： {count}，最大允许：{max}", | ||
| "Error occurred while retrieving comment with id {id}" : "检索 id 为 {id} 的评论出错", | ||
| "Error occurred while updating comment with id {id}" : "更新 id 为 {id} 的评论出错", |
There was a problem hiding this comment.
There was a box character at the beginning of this string
There was a problem hiding this comment.
Btw I also fixed this on transifex, this is just to confirm that the script works.
LukasReschke
left a comment
There was a problem hiding this comment.
Nice. But you need to add the test also to the matrix at the end of the .drone.yml :)
| * | ||
| */ | ||
|
|
||
| $directories = [ |
There was a problem hiding this comment.
this might get out of sync at some point, therefore it would make sense to just iterate over all subdirs in apps. https://github.com/nextcloud/server/pull/4485/files already handles non-existing l10n directories.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Codecov Report
@@ Coverage Diff @@
## master #4485 +/- ##
============================================
+ Coverage 53.96% 53.96% +<.01%
Complexity 21679 21679
============================================
Files 1272 1272
Lines 75789 75789
============================================
+ Hits 40898 40899 +1
+ Misses 34891 34890 -1
|
|
@LukasReschke fixed |
|
@nickvergessen Could you also add this to the stable branches and all the apps we release 🙈 |
|
No need to backport, the translation files contain the strings of 12, 11 and 10? So the check result will be the same for all? |
Ah right 🙈 But could you create this for most of the apps out there? |
Fix #3189
I'm sick of this, lets add a job to check this, so we dont release something like this again...