fix(auth): Keep redirect URL during 2FA setup and challenge#44745
Merged
ChristophWurst merged 1 commit intomasterfrom Apr 23, 2024
Merged
fix(auth): Keep redirect URL during 2FA setup and challenge#44745ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
| $params = [ | ||
| 'redirect_url' => $this->request->getParam('redirect_url'), | ||
| ]; | ||
| if (!isset($params['redirect_url']) && isset($this->request->server['REQUEST_URI'])) { |
Check notice
Code scanning / Psalm
NoInterfaceProperties
| $params = [ | ||
| 'redirect_url' => $this->request->getParam('redirect_url'), | ||
| ]; | ||
| if (!isset($params['redirect_url']) && isset($this->request->server['REQUEST_URI'])) { |
Member
There was a problem hiding this comment.
I still find it disturbing that isset is false when the value is null...
nickvergessen
approved these changes
Apr 9, 2024
6083dad to
8fbd8cc
Compare
| */ | ||
| #[FrontpageRoute(verb: 'GET', url: 'login/setupchallenge/{providerId}')] | ||
| public function setupProvider(string $providerId) { | ||
| public function setupProvider(string $providerId, ?string $redirect_url = null) { |
Check notice
Code scanning / Psalm
MissingReturnType
| */ | ||
| #[FrontpageRoute(verb: 'POST', url: 'login/setupchallenge/{providerId}')] | ||
| public function confirmProviderSetup(string $providerId) { | ||
| public function confirmProviderSetup(string $providerId, ?string $redirect_url = null) { |
Check notice
Code scanning / Psalm
MissingReturnType
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
dc9f352 to
22dc278
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The redirect URL is crucial when a user is sent to Nextcloud to grant access for clients during the login flow. Without this, users will log in and land on the default page instead of the grant page for the setup.
How to test
Master: land at /apps/dashboard, /apps/files or whatever the default is
Here: land at /settings/user
TODO
Checklist