fix(AppFramework): Fix error message about 204 not allowing custom headers#44726
Merged
provokateurin merged 1 commit intomasterfrom Apr 8, 2024
Merged
Conversation
…aders Signed-off-by: provokateurin <kate@provokateurin.de>
bigcat88
approved these changes
Apr 8, 2024
nickvergessen
approved these changes
Apr 8, 2024
Member
nickvergessen
left a comment
There was a problem hiding this comment.
https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/HttpFoundation/Response.php#L246-L249
Symfony also only removes the content related headers, so others seem okay.
Member
|
/backport to stable29 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
204 does allow custom headers, only 304 forbids them:
server/lib/public/AppFramework/Http/Response.php
Lines 208 to 218 in 1d5d8d4
For reference: nextcloud/openapi-extractor#111
Checklist