feat(trashbin): Add deleted by properties#44643
Merged
Conversation
Altahrim
reviewed
Apr 4, 2024
c66be6e to
3b338fe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
3b338fe to
ab46e8a
Compare
ab46e8a to
7b62df5
Compare
d1672d9 to
1c3b229
Compare
3b46ab2 to
6e49424
Compare
Member
Author
|
Switched the column back to nullable to fix potential migration errors with oracle which converts empty string to null |
icewind1991
approved these changes
Apr 22, 2024
sorbaugh
approved these changes
Apr 23, 2024
come-nc
reviewed
Apr 23, 2024
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Did you test that with groupfolders?
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
6e49424 to
583517e
Compare
Member
Author
Seems it breaks groupfolders as it implements a custom trash backend, documented the change here nextcloud/documentation#11757 App devs will have to update their custom trash backends to support this for 30 |
4 tasks
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store and provide a new
trashbin-deleted-by-idandtrashbin-deleted-by-display-nameDAV propertiesExample PROPFIND request data
Checklist