fix(CSP): Add CSP nonce by default and convert browserSupportsCspV3 to blacklist#44412
Merged
fix(CSP): Add CSP nonce by default and convert browserSupportsCspV3 to blacklist#44412
browserSupportsCspV3 to blacklist#44412Conversation
Closed
Contributor
|
Tested with Talk iOS on iOS 15.5 and 17.0 and both worked for me. |
MichaIng
approved these changes
Mar 23, 2024
Member
MichaIng
left a comment
There was a problem hiding this comment.
Since IE is not (officially) supported by Nextcloud anymore, even the blacklist might not be needed. But good to have the facility, so we can add further entries in the unlikely but possible case that there are other browsers not supporting CSP nonce sources.
skjnldsv
approved these changes
Mar 23, 2024
Altahrim
approved these changes
Mar 25, 2024
Merged
… to blocklist Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
60428fc to
5a513c9
Compare
juliusknorr
approved these changes
Mar 26, 2024
8 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every modern browser ("modern" like every version since 2013 (over 10 years now!)) support the nonce src.
So we should add it by default and only keep a blacklist instead.
This way even users with for us unknown user agents get the more secure version.
Checklist