Skip to content

feat: allow limit unified search to folder#43963

Merged
nfebe merged 4 commits intomasterfrom
42915-search-in-folder
Mar 7, 2024
Merged

feat: allow limit unified search to folder#43963
nfebe merged 4 commits intomasterfrom
42915-search-in-folder

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Mar 3, 2024 •
edited
Loading

Summary

Screencast

search-in-folder.webm

@nfebe nfebe force-pushed the 42915-search-in-folder branch 3 times, most recently from b32af2e to 0532151 Compare March 3, 2024 14:11
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 3, 2024
View reviewed changes
@nfebe nfebe force-pushed the 42915-search-in-folder branch 5 times, most recently from ad9bfc5 to d8a2f47 Compare March 4, 2024 08:27
emoral435
emoral435 reviewed Mar 5, 2024
View reviewed changes
@nfebe nfebe mentioned this pull request Mar 6, 2024
Merged
2 tasks
@sorbaugh sorbaugh mentioned this pull request Mar 6, 2024
Merged
@nfebe nfebe force-pushed the 42915-search-in-folder branch 4 times, most recently from 1e52dd1 to cc178d5 Compare March 7, 2024 12:46
@nfebe nfebe mentioned this pull request Mar 7, 2024
Open
3 tasks
@nfebe nfebe marked this pull request as ready for review March 7, 2024 12:56
@nfebe nfebe requested a review from skjnldsv as a code owner March 7, 2024 12:56
@nfebe nfebe force-pushed the 42915-search-in-folder branch from cc178d5 to 59837ca Compare March 7, 2024 13:04
nfebe
nfebe commented Mar 7, 2024
View reviewed changes
Copy link
Contributor Author

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invitation to check if provider and structure of call is correct...

cc: @Altahrim

Thanks in advance :)

@nfebe nfebe added this to the Nextcloud 29 milestone Mar 7, 2024
@nfebe nfebe force-pushed the 42915-search-in-folder branch 2 times, most recently from ab91eee to 3e981a2 Compare March 7, 2024 14:19
@nfebe nfebe requested a review from skjnldsv March 7, 2024 14:20
skjnldsv
skjnldsv reviewed Mar 7, 2024
View reviewed changes
@nfebe nfebe force-pushed the 42915-search-in-folder branch 2 times, most recently from 5db3961 to 3acb022 Compare March 7, 2024 14:26
@nfebe nfebe requested a review from skjnldsv March 7, 2024 14:27
@nfebe nfebe force-pushed the 42915-search-in-folder branch from 3acb022 to 94380f9 Compare March 7, 2024 14:32
susnux
susnux reviewed Mar 7, 2024
View reviewed changes
@nfebe nfebe force-pushed the 42915-search-in-folder branch 2 times, most recently from f95925c to 696a068 Compare March 7, 2024 16:31
@nfebe nfebe requested a review from susnux March 7, 2024 16:32
nfebe
nfebe commented Mar 7, 2024
View reviewed changes
Copy link
Contributor Author

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers.

apps/files/composer/composer/autoload_static.php Outdated
'OCA\\Files\\' => 10,
),
);
class ComposerStaticInitFiles {
Copy link
Contributor Author

@nfebe nfebe Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is separate commit for this formatting change, done my cs:fix to help reviewers.

@nfebe
Copy link
Contributor Author

nfebe commented Mar 7, 2024

/compile /

@nfebe nfebe force-pushed the 42915-search-in-folder branch from 4e8aec8 to d534b74 Compare March 7, 2024 18:55
@blizzz
Copy link
Member

blizzz commented Mar 7, 2024

@fenn-cs signoff is missing in commit 3f1fb41

@nfebe
refactor: use TypeScript for unified-search boostrap file
0fd31cd 
This would allow us to type guard what is sent to`registerFilterAction`
for unified search, so that incompatibilties are caught quickly.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the 42915-search-in-folder branch from d534b74 to 8bcab3a Compare March 7, 2024 19:20
@nfebe
Copy link
Contributor Author

nfebe commented Mar 7, 2024

@fenn-cs signoff is missing in commit 3f1fb41

Thanks for catching, resolved :)

@blizzz
Copy link
Member

blizzz commented Mar 7, 2024

other CI is also red though :(

nfebe added 2 commits March 7, 2024 21:10
@nfebe nfebe force-pushed the 42915-search-in-folder branch from 8bcab3a to a3f6380 Compare March 7, 2024 20:11
@nfebe
Copy link
Contributor Author

nfebe commented Mar 7, 2024

/compile /

@nextcloud-command
chore(assets): Recompile assets
108e694 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit dc79591 into master Mar 7, 2024
@nfebe nfebe deleted the 42915-search-in-folder branch March 7, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

@artonge artonge Awaiting requested review from artonge

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

+1 more reviewer

@emoral435 emoral435 emoral435 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2. developing Work in progress feature: files feature: search

Projects

📁 Files team
Archived in project

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

🔍📂 Unified Search in specific folder

6 participants

@nfebe @blizzz @susnux @skjnldsv @emoral435 @nextcloud-command