Skip to content

fix(sharing): Move video verification option to password and hide without Talk#43519

Merged
nickvergessen merged 2 commits intomasterfrom
bugfix/41244/improve-video-verification-option
Feb 13, 2024
Merged

fix(sharing): Move video verification option to password and hide without Talk#43519
nickvergessen merged 2 commits intomasterfrom
bugfix/41244/improve-video-verification-option

Conversation

@nickvergessen
Copy link
Member

TODO

  • Move it right below the password option which makes it visible
  • Hide when Talk is not enabled

Checklist

…hout Talk

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
// Anything else should be fine
return true
// Is Talk enabled?
return OC.appswebroots.spreed !== undefined
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same logic as 26:

},
/**
* Is Talk enabled?
*
* @return {boolean}
*/
isTalkEnabled() {
return OC.appswebroots.spreed !== undefined
},

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 12, 2024

/backport fa4b327 to stable28

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 12, 2024

/backport fa4b327 to stable27

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Talk app enabled/disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When customizing a link share there is the option "Video verification" despite the "Nextcloud Talk" App isn't installed on the instance

3 participants