fix(files): drop to folder path and user feedback#43267
Merged
Conversation
8 tasks
ShGKme
reviewed
Feb 1, 2024
ShGKme
reviewed
Feb 1, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
Part of it has been fixed already, some remains: Issue 1
Peek.02-02-2024.08-06.mp4Issue 2Considering the following path: Peek.02-02-2024.08-12.mp4 |
8 tasks
40498d9 to
95c0a90
Compare
ShGKme
approved these changes
Feb 5, 2024
Member
Author
|
/compile rebase / |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
95c0a90 to
5f4a0d9
Compare
Member
Author
|
/backport to stable28 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review two commits separately
Uploading: addaa9b
/Photos/Photos/Landscapes)t.dataTransfer.files.forEach is not a functionCleanup: 23d934f
On a previous version, we were using the default
CheckboxRadioSwitchmodelbehaviour, that only works with string. WithdefineComponentwe now see that there are a lot of typing issues. We switch back to properly using anumberand not astringFileEntry mixin: 1d46720
Much cleaner to not have duplicate code 🙈