[IAppConfig] format values based on type#43258
Closed
ArtificialOwl wants to merge 1 commit intomasterfrom
Closed
Conversation
56af4d1 to
83b4b44
Compare
83b4b44 to
cf673bc
Compare
16273db to
58c6124
Compare
Merged
58c6124 to
b984382
Compare
Merged
b984382 to
0443c8f
Compare
Altahrim
reviewed
Mar 14, 2024
0443c8f to
d84954c
Compare
43338de to
a697c94
Compare
Member
Author
|
I have found a performance issue as this PR would load lazy config values when searching for the enabled apps at boot. Adding also a test to confirm that no lazy config values are loaded during the normal boot of Nextcloud |
a697c94 to
0cf37c8
Compare
emoral435
approved these changes
Mar 15, 2024
Member
|
Merged
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
0cf37c8 to
a667224
Compare
Member
Author
test was not related to the PR. I will implement it in a separated PR |
skjnldsv
requested changes
Mar 19, 2024
Member
skjnldsv
left a comment
There was a problem hiding this comment.
I would have liked this covered in Tests before we get this in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
returns formated values based on type when calling
getAllValues()andsearchValues()note: deprecated method
getValues()usegetAllValues()but if the config value is defined as MIXED (default), the value is kept as a string.original:
new: