feat(perf): add cache for authtoken lookup#43057
Merged
Conversation
eb6cd37 to
2a649b2
Compare
2a649b2 to
07112b8
Compare
07112b8 to
e7555f9
Compare
e7555f9 to
d1b3490
Compare
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested & works
Blackfire confirms that 2 requests are shaved off most requests.
Loading my dev env dashboard causes 18 auth token SELECTs on master and 1 here.
🚀
fd3b086 to
9ebd2e4
Compare
9ebd2e4 to
5e684f2
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
5e684f2 to
d1189f9
Compare
ChristophWurst
approved these changes
Feb 28, 2024
skjnldsv
approved these changes
Mar 1, 2024
Merged
8 tasks
Member
|
Any chance this could be backported? |
Collaborator
Author
|
/backport to stable28 |
Collaborator
Author
|
/backport to stable27 |
Collaborator
Author
|
/backport to stable26 |
3 tasks
|
The backport to # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b backport/43057/stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d1189f92
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43057/stable26Error: Failed to push branch backport/43057/stable26: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add cache for
authtokenlookupChecklist