Conversation
sorbaugh
approved these changes
Jan 22, 2024
Contributor
|
For my understanding, why not adjust this in server/apps/theming/lib/ThemingDefaults.php Lines 508 to 510 in 64ccc1e 🤔 |
Contributor
Author
Better would be in For a general fix I currently prepare this one: #42977 |
Merged
Pytal
approved these changes
Jan 22, 2024
This comment was marked as resolved.
This comment was marked as resolved.
f70a37b to
d2d5e7d
Compare
sorbaugh
approved these changes
Jan 22, 2024
This comment was marked as resolved.
This comment was marked as resolved.
… on themes Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
d2d5e7d to
afa56bb
Compare
Contributor
Author
|
cypress unrelated |
skjnldsv
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On themes we replace the default color with the accessible color, so we also need to do this on the capabilities.
This worked previously but as we now enforce contrasts of the text color clients that use the capabilities changes to black text on that color.
Checklist