fix: Use viewBox instead of viewbox in SVGs#43027
Merged
provokateurin merged 2 commits intomasterfrom Jan 22, 2024
Merged
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
bigcat88
approved these changes
Jan 22, 2024
come-nc
approved these changes
Jan 22, 2024
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Should we have some kind of lint svg CI workflow?
Member
Author
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Member
We should at least make sure this here is not breaking it again any time soon: We can of course also run that script on CI and ensure an empty diff. But I would see it as a different task |
Member
Author
I ran it, it didn't modify the attribute 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The correct attribute name is
viewBoxand notviewbox: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/viewBoxChecklist