enh(profile): Refactor code to use vue components and styles where possible#42668
Merged
enh(profile): Refactor code to use vue components and styles where possible#42668
Conversation
b9517e7 to
8742fab
Compare
Contributor
|
unrelated comment to the PR - wish I could review this PR while at University because it looks like a good change, but my computer has 3% 😔 will try to review later if not merged ! |
emoral435
approved these changes
Jan 10, 2024
skjnldsv
approved these changes
Jan 10, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8742fab to
e1cd0f3
Compare
Member
Merged with red CI breaking it. |
| use OCP\UserStatus\IManager as IUserStatusManager; | ||
|
|
||
| #[IgnoreOpenAPI] | ||
| #[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)] |
Member
There was a problem hiding this comment.
Sadly this is not supported by the tool yet.... Still waiting for @provokateurin in nextcloud/openapi-extractor#24
Contributor
Author
|
/backport to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor profile view to make use of standard vue components. This reduces code complexity and duplicated code.
Moreover some visual bugs are resolved, e.g. the profile action buttons now work correctly (see below).
Also a lot of custom styling is removed in favor of our component styles from the nextcloud vue library.
Checklist