Fix SVG's for social media links#42586
Merged
JuliaKirschenheuter merged 1 commit intomasterfrom Jan 5, 2024
Merged
Conversation
szaimen
reviewed
Jan 4, 2024
apps/settings/templates/settings/personal/development.notice.php
Outdated
Show resolved
Hide resolved
Contributor
|
/backport to stable28 |
Contributor
|
I'll wait for @nimishavijay 's response on the color before giving a review, but it looks good to me - if she clears it, i'll sign off on it :) |
Contributor
|
I also saw that in the issue itself, several designers agreed with making the SVG's the same text-black that we use (ping me if you need the hex) - so that may be preferable |
1987d31 to
ec4f20e
Compare
szaimen
reviewed
Jan 5, 2024
apps/settings/templates/settings/personal/development.notice.php
Outdated
Show resolved
Hide resolved
szaimen
reviewed
Jan 5, 2024
apps/settings/templates/settings/personal/development.notice.php
Outdated
Show resolved
Hide resolved
szaimen
reviewed
Jan 5, 2024
apps/settings/templates/settings/personal/development.notice.php
Outdated
Show resolved
Hide resolved
szaimen
reviewed
Jan 5, 2024
apps/settings/templates/settings/personal/development.notice.php
Outdated
Show resolved
Hide resolved
szaimen
reviewed
Jan 5, 2024
apps/settings/templates/settings/personal/development.notice.php
Outdated
Show resolved
Hide resolved
szaimen
reviewed
Jan 5, 2024
szaimen
approved these changes
Jan 5, 2024
Contributor
szaimen
left a comment
There was a problem hiding this comment.
LGTM from design perspective :)
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
58584d3 to
eed6817
Compare
ShGKme
approved these changes
Jan 5, 2024
Contributor
ShGKme
left a comment
There was a problem hiding this comment.
LGTM from implementation perspective
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SVG's for social media links
Checklist