feat(comments): Add a meta data column for comments#42209
Merged
nickvergessen merged 2 commits intomasterfrom Dec 15, 2023
Merged
feat(comments): Add a meta data column for comments#42209nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
2106989 to
09afaa2
Compare
6 tasks
marcelklehr
requested changes
Dec 13, 2023
Member
marcelklehr
left a comment
There was a problem hiding this comment.
Psalm complains about the usage of updateQuery in the update method
be577c2 to
b5a6376
Compare
marcelklehr
approved these changes
Dec 14, 2023
come-nc
approved these changes
Dec 14, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
…ore can be removed Signed-off-by: Joas Schilling <coding@schilljs.com>
d18634c to
226134a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows apps to store meta-data information into the comments table. A usecase that exists since a longer time is being able to indicate that a message was sent silently.
For the upcoming "Edit message" we want to store the actor and time information of the last person that edited a chat message, to avoid another database query on every chat request.
While changing the table anyway, I enforced the currently optional reference_id column which talk also relies on.
Checklist