fix(theming): Fix color inverted icons based on theming and dark mode#41855
Merged
nickvergessen merged 2 commits intomasterfrom Nov 29, 2023
Merged
fix(theming): Fix color inverted icons based on theming and dark mode#41855nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
szaimen
approved these changes
Nov 29, 2023
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this @nickvergessen! :)
Tested and seems to work fine but found one remaining spot where it is broken:

Member
|
/backport to stable28 |
Member
Author
AndyScherzinger
approved these changes
Nov 29, 2023
Contributor
|
Nodb failure seems related https://drone.nextcloud.com/nextcloud/server/45036/9/4 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
45644e7 to
d05a13f
Compare
Member
Author
|
/backport to stable28 |
Contributor
|
Seems like it didnt work :/ |
Member
Author
|
Compiled assets... will do manually |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Checklist