[stable24] fix(dav): Name properties table columns explicitly#41775
Closed
ChristophWurst wants to merge 1 commit intostable24from
Closed
[stable24] fix(dav): Name properties table columns explicitly#41775ChristophWurst wants to merge 1 commit intostable24from
ChristophWurst wants to merge 1 commit intostable24from
Conversation
And ignore any optional columns. This allows instances to run the expensive query for the new column in 25 in the background, while keeping the 24 installation live. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Member
|
Looking at the usages more closely i think it should be safe to even run without this patch as we continue only using propertyname and propertyvalue so would not care about the extra column. https://github.com/nextcloud/server/blob/fix/dav/explicit-properties-column-names/apps/dav/lib/DAV/CustomPropertiesBackend.php#L243 Insert is also fine as we have a default value on the column |
Member
Author
|
Good catch. That seems to be the case indeed! |
Member
Author
|
Obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
And ignore any optional columns. This allows instances to run the expensive query for the new column in 25 in the background, while keeping the 24 installation live.
TODO
Checklist