[stable26] Clear progress bar text when hiding it#40846
Merged
Conversation
When files are uploaded the progress bar text is set accordingly. However, other operations that show the progress bar, like deleting files, do not explicitly set any text. Due to that, when the progress bar was shown again after uploading files the text did not match the operation. To solve that now the text is cleared when the progress bar is hidden (it is not cleared when it is shown as in some cases the text is set already before showing the progress bar). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Merged
blizzz
approved these changes
Oct 10, 2023
danxuliu
approved these changes
Oct 10, 2023
Member
danxuliu
left a comment
There was a problem hiding this comment.
Tested and works 👍
CI failure is unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #40572