[stable26] Do not throw while restoring unloaded files list entries#40606
Merged
[stable26] Do not throw while restoring unloaded files list entries#40606
Conversation
Make sure to only remove elements from file list (while restoring) if the element was added to the file list (might not be added, if the list is scrolling). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
/backport 95acf8a to stable25 |
artonge
approved these changes
Sep 25, 2023
szaimen
approved these changes
Sep 25, 2023
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Makes sense but didnt test
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When restoring files from trashbin while not all files are loaded into the file list (e.g. overflowing -> scrolling), then the restore all action throws because the
$elof the unloaded elements in undefined.In this case simply do not call remove.
For 27 this is fixed with files2vue.
Checklist