Merged
Conversation
5ae9081 to
19f7fa8
Compare
Member
Author
|
@provokateurin do you think #40575 will fix psalm analysis ? should we cherrypick ? |
Member
|
No my PR won't fix it. You need to remove all the new |
ef4d72e to
1af7102
Compare
Member
|
I think you should remove the annotation instead of supressing it |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
1af7102 to
0fac750
Compare
provokateurin
approved these changes
Sep 22, 2023
sorbaugh
approved these changes
Sep 23, 2023
nfebe
approved these changes
Sep 23, 2023
Merged
|
For info, NC 27.1.2 was deployed at PSNC in Poland, a site of the ScienceMesh (the infra where the initial report #39001 originated), and I can confirm basic sharing functionally works as expected. Thanks for the effort! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #39574