Skip to content

Migrate applications away from deprecated ILogger#40508

Merged
come-nc merged 1 commit intomasterfrom
fix/migrate-apps-away-from-ilogger
Sep 21, 2023
Merged

Migrate applications away from deprecated ILogger#40508
come-nc merged 1 commit intomasterfrom
fix/migrate-apps-away-from-ilogger

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 19, 2023 •
edited
Loading

See #32127

Summary

Migrate applications away from deprecated ILogger
Left alone jobs and a few other cases for now.
Also migrated to PHP8 promoted constructor properties modified classes.

Checklist

@come-nc come-nc added 3. to review Waiting for reviews technical debt labels Sep 19, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Sep 19, 2023
@come-nc come-nc self-assigned this Sep 19, 2023
@come-nc come-nc mentioned this pull request Sep 19, 2023
Closed
24 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 19, 2023
View reviewed changes
apps/files/lib/Controller/DirectEditingViewController.php

public function __construct($appName, IRequest $request, IEventDispatcher $eventDispatcher, IManager $manager, ILogger $logger) {
public function __construct(
$appName,

Check notice

Code scanning / Psalm

MissingParamType

Parameter $appName has no provided type
apps/updatenotification/lib/AppInfo/Application.php
IUserSession $userSession,
IAppManager $appManager,
IGroupManager $groupManager,
IAppContainer $appContainer,

Check notice

Code scanning / Psalm

DeprecatedInterface

Interface OCP\AppFramework\IAppContainer is marked as deprecated
apps/workflowengine/lib/Manager.php
IConfig $config,
ICacheFactory $cacheFactory,
protected IDBConnection $connection,
protected IServerContainer $container,

Check notice

Code scanning / Psalm

DeprecatedInterface

Interface OCP\IServerContainer is marked as deprecated
@nickvergessen
Copy link
Member

nickvergessen commented Sep 20, 2023 

1) OCA\WorkflowEngine\Tests\ManagerTest::testUpdateOperation
TypeError: OCA\WorkflowEngine\Entity\File::__construct(): Argument #4 ($shareManager) must be of type OCP\Share\IManager, Mock_LoggerInterface_dba463ac given

/home/runner/work/server/server/apps/workflowengine/lib/Entity/File.php:78
/home/runner/work/server/server/apps/workflowengine/tests/ManagerTest.php:413
/home/runner/work/server/server/apps/workflowengine/lib/Manager.php:445
/home/runner/work/server/server/apps/workflowengine/lib/Manager.php:499
/home/runner/work/server/server/apps/workflowengine/lib/Manager.php:375
/home/runner/work/server/server/apps/workflowengine/tests/ManagerTest.php:436

@come-nc
Migrate applications away from deprecated ILogger
0a9371f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/migrate-apps-away-from-ilogger branch from dd3855a to 0a9371f Compare September 21, 2023 09:57
@come-nc come-nc enabled auto-merge September 21, 2023 09:57
@come-nc come-nc disabled auto-merge September 21, 2023 13:12
@come-nc come-nc merged commit ff9de2e into master Sep 21, 2023
@come-nc come-nc deleted the fix/migrate-apps-away-from-ilogger branch September 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@come-nc @nickvergessen @ChristophWurst @miaulalala