Revert "Do not do redirect handling when loggin out"

[haslersn]

This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: #16310

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[kesselb]

Good finding 👍

[nickvergessen]

Are we sure it does by now?

[haslersn]

The logout redirect still has this code, so your question is unrelated to this PR which only removes the subsequent (i.e., 2nd) redirect. See:

server/core/Controller/LoginController.php

Line 101 in 2bd0f07

['clear' => true] // this param the code in login.js may be removed when the "Clear-Site-Data" is working in the browsers

[haslersn]

What's keeping this from getting merged?

[kesselb]

What's keeping this from getting merged?

The failing DCO check, for example.
Please rebase your branch (to pull in the latest changes from master) and sign off the commits (to pass the DCO check).

[haslersn]

@kesselb is was signed off, but apparently there was a mismatch between committer email and sign-off email. Should be fixed now.

[haslersn]

What's now keeping this from getting merged?

[come-nc]

I rebased for CI, I do not understand enough about this for approving, I’ll follow @kesselb lead on this one.

[kesselb]

Hello Hello, it's been a while and I don't remember all the details. I think the middleware was added to address the redirect cause by clear-site-data executionContext and can, as we removed executionContext again, go.