Skip to content

Migrate files sharing to PSR LoggerInterface#39169

Merged
Altahrim merged 1 commit intomasterfrom
fix/migrate-to-psr-logger-interface-files_sharing
Jul 11, 2023
Merged

Migrate files sharing to PSR LoggerInterface#39169
Altahrim merged 1 commit intomasterfrom
fix/migrate-to-psr-logger-interface-files_sharing

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Jul 5, 2023

See #32127

Summary

Remove OCP\ILogger from apps/files_sharing and use Psr\Log\LoggerInterface` instead.

@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_sharing branch from d4a8c60 to aac558f Compare July 5, 2023 14:54
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 5, 2023
View reviewed changes
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 6, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 6, 2023
@solracsf solracsf added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 6, 2023
@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_sharing branch from aac558f to fed46aa Compare July 6, 2023 08:01
@Altahrim Altahrim self-assigned this Jul 6, 2023
@Altahrim Altahrim mentioned this pull request Jul 6, 2023
Closed
24 tasks
@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_sharing branch from fed46aa to 3aab8c3 Compare July 6, 2023 09:56
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 6, 2023
View reviewed changes
@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_sharing branch from 3aab8c3 to d8d779c Compare July 6, 2023 10:05
@Altahrim
Migrate files sharing to PSR LoggerInterface
29c1848 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the fix/migrate-to-psr-logger-interface-files_sharing branch from d8d779c to 29c1848 Compare July 6, 2023 12:09
@Altahrim Altahrim marked this pull request as ready for review July 7, 2023 06:51
@Altahrim Altahrim requested review from a team, ArtificialOwl, come-nc and icewind1991 and removed request for a team July 7, 2023 06:52
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 7, 2023
artonge
artonge approved these changes Jul 11, 2023
View reviewed changes
@Altahrim Altahrim merged commit 12ee258 into master Jul 11, 2023
@Altahrim Altahrim deleted the fix/migrate-to-psr-logger-interface-files_sharing branch July 11, 2023 09:15
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels

enhancement

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@Altahrim @artonge @skjnldsv @solracsf