Skip to content

Refactors lib/private/FullTextSearch#38996

Merged
skjnldsv merged 2 commits intonextcloud:masterfrom
fsamapoor:refactor_lib_private_fulltextsearch
Feb 23, 2024
Merged

Refactors lib/private/FullTextSearch#38996
skjnldsv merged 2 commits intonextcloud:masterfrom
fsamapoor:refactor_lib_private_fulltextsearch

Conversation

@fsamapoor
Copy link
Member

@fsamapoor fsamapoor commented Jun 25, 2023

Following previous PRs taking advantage of PHP8's constructor property promotion in /core/ namespace, I have also made the required adjustments to the classes in /lib/private/FullTextSearch namespace.

The improvements in this PRs include:

  • Using PHP8's constructor property promotion
  • Using early returns
  • Adding return types
  • Adding types to properties
  • Removing redundant docblocks

@szaimen szaimen added 3. to review Waiting for reviews technical debt labels Jun 25, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 25, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team June 25, 2023 19:59
fsamapoor
fsamapoor commented Jun 27, 2023
View reviewed changes
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from 629e918 to b920fb1 Compare October 3, 2023 05:45
@fsamapoor fsamapoor requested a review from come-nc October 3, 2023 05:48
come-nc
come-nc requested changes Oct 5, 2023
View reviewed changes
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch 2 times, most recently from 93c565c to 217101a Compare October 10, 2023 06:46
@fsamapoor fsamapoor requested a review from come-nc October 10, 2023 07:42
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from 217101a to a7beea1 Compare November 7, 2023 06:12
@fsamapoor
Copy link
Member Author

fsamapoor commented Nov 7, 2023

@come-nc Anything I need to change in this PR?

I believe the integration workflow may have timed out.

come-nc
come-nc reviewed Nov 7, 2023
View reviewed changes
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from a7beea1 to e03294a Compare November 9, 2023 07:55
@come-nc
Copy link
Contributor

come-nc commented Nov 9, 2023

@fsamapoor autoloaders are not up to date, probably because of the new Exception class, please run build/autoloaderchecker.sh and commit the files with new classes.

@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from e03294a to 4312e2d Compare November 9, 2023 09:27
@nickvergessen nickvergessen removed their request for review November 9, 2023 10:03
@fsamapoor
Copy link
Member Author

fsamapoor commented Nov 9, 2023 •
edited
Loading

@fsamapoor autoloaders are not up to date, probably because of the new Exception class, please run build/autoloaderchecker.sh and commit the files with new classes.

@come-nc Done.

ChristophWurst
ChristophWurst reviewed Nov 9, 2023
View reviewed changes
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from 4312e2d to 82d2ddf Compare November 9, 2023 11:04
fsamapoor
fsamapoor commented Nov 9, 2023
View reviewed changes
This was referenced Nov 10, 2023
Merged
Merged
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from 82d2ddf to 05e043b Compare November 15, 2023 05:55
@blizzz blizzz mentioned this pull request Nov 20, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from 05e043b to ece1e78 Compare December 1, 2023 12:25
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from ece1e78 to 1e76d5e Compare January 3, 2024 06:53
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from 1e76d5e to 144e809 Compare January 11, 2024 11:18
fsamapoor and others added 2 commits January 15, 2024 10:36
@fsamapoor @come-nc
Refactors lib/private/FullTextSearch.
2845071 
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@fsamapoor @come-nc
Adds new exception to check for the availability of the index.
cdf9d94 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@fsamapoor fsamapoor force-pushed the refactor_lib_private_fulltextsearch branch from 144e809 to cdf9d94 Compare January 15, 2024 07:06
@skjnldsv skjnldsv merged commit 1629b41 into nextcloud:master Feb 23, 2024
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@fsamapoor fsamapoor deleted the refactor_lib_private_fulltextsearch branch February 23, 2024 20:47
@juliusknorr juliusknorr mentioned this pull request Feb 26, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nfebe nfebe nfebe approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@miaulalala miaulalala Awaiting requested review from miaulalala

@st3iny st3iny Awaiting requested review from st3iny

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

8 participants

@fsamapoor @come-nc @icewind1991 @ChristophWurst @nfebe @blizzz @skjnldsv @szaimen