[stable26] Add commands for basic file actions#38250
Conversation
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
backport incomplete |
|
moving to 26.0.4 |
|
moving to 26.0.5 |
|
moving to 26.0.6 If there are no updates in any form until building 26.0.6, I will close this PR. |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
… as argument instead of option Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
985fbc1 to
2f662bf
Compare
| return 1; | ||
| } | ||
| $source = $node->fopen('r'); | ||
| if (!$source) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| return 1; | ||
| } | ||
| $source = $node->fopen('r'); | ||
| if (!$source) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| } | ||
| if ($node instanceof File) { | ||
| $target = $node->fopen('w'); | ||
| if (!$target) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| } | ||
| if ($node instanceof File) { | ||
| $target = $node->fopen('w'); | ||
| if (!$target) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
|
moving to 26.0.7 due to missing reviews, but thanks @icewind1991 for bringing this back to life |
backport of #37971