Send Clear-Site-Data header and let browsers ignore it if unsupported#37405
Merged
Send Clear-Site-Data header and let browsers ignore it if unsupported#37405
Conversation
Member
|
Do we gain anything to just not send it if safari? If so, we should not even bother and send it for all browsers, no? |
Member
Author
|
Sure but as i didn't knew the reason why some were balcklisted i assumed it was a compatiblity issue; but yes, this is just a header, browsers will just ignore it if unsupported. |
Member
Author
|
@skjnldsv I've changed the code accordingly. |
d708174 to
cfd7a57
Compare
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Don't send Clear-Site-Data to Safari Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix lint Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
artonge
approved these changes
Mar 27, 2023
skjnldsv
approved these changes
Mar 28, 2023
skjnldsv
requested changes
Mar 28, 2023
Member
skjnldsv
left a comment
There was a problem hiding this comment.
tests/Core/Controller/LoginControllerTest.php:160 needs a fix :)
skjnldsv
approved these changes
Mar 28, 2023
8 tasks
Member
4 tasks
Contributor
|
I cancelled the regression code of the PR here: #42544. |
HLFH
added a commit
to HLFH/server
that referenced
this pull request
Jan 2, 2024
HLFH
added a commit
to HLFH/server
that referenced
this pull request
Jan 2, 2024
Signed-off-by: Gaspard d'Hautefeuille <github@dhautefeuille.eu>
6 tasks
szaimen
pushed a commit
to HLFH/server
that referenced
this pull request
Jan 5, 2024
Signed-off-by: Gaspard d'Hautefeuille <github@dhautefeuille.eu>
backportbot bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Gaspard d'Hautefeuille <github@dhautefeuille.eu>
skjnldsv
pushed a commit
that referenced
this pull request
Feb 22, 2024
Signed-off-by: Gaspard d'Hautefeuille <github@dhautefeuille.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data#browser_compatibility only Safari don't support it.
Checklist