fix(session): Fix DAVx5 sync problems by partial reverting session changes#37306
fix(session): Fix DAVx5 sync problems by partial reverting session changes#37306
Conversation
…anges Temporary disabled the short cut again to solve issues with CalDAV/CardDAV clients like DAVx5 that use cookies and need a session. See #37277 (comment) and the other comments for further information. Signed-off-by: Joas Schilling <coding@schilljs.com>
|
/backport to stable26 |
Test steps
I followed these steps four times. Twice on master and twice on this branch.
|
ChristophWurst
left a comment
There was a problem hiding this comment.
Allows DAVx5 to sync again on my dev instance
|
I confirm that applying this (=commenting out lines 414…420) leads to DAVx5 syncing my address book against my instance running NC26.0.0RC3 with NGINX and PHP-FPM 8.2 on Arch. |
st3iny
left a comment
There was a problem hiding this comment.
Tested with Davx5 on c.nc.c and syncing works again.
Important: turn debug mode off. The bug doesn't show otherwise 🙄 |
|
One issue reported with Postgres and CalDAV resulting in different payload. Related? |
26 is not suffering from it |
Does this have (significant) side effects, or are they unrelated? |
No, the used API does not sort and just assumes results are sorted by ID.
|
This comment was marked as resolved.
This comment was marked as resolved.
|
I’m wondering if this could not be fixed by adding the code back but only after the ini_set calls? |
Summary
Temporary disabled the short cut again to solve issues with CalDAV/CardDAV clients like DAVx5 that use cookies and need a session. See #37277 (comment) and the other comments for further information.
Checklist