Do not send a pagination control with size = 0 if cookie is empty#37197
Merged
Do not send a pagination control with size = 0 if cookie is empty#37197
Conversation
It only makes sense to send a pagination control with size 0 with a cookie to abandon a paged search. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
/backport to stable26 |
kesselb
approved these changes
Mar 13, 2023
Contributor
kesselb
left a comment
There was a problem hiding this comment.
Thank you 👍
Code makes sense and the objectclass detection works again 🎉
Screencast.from.2023-03-13.16-41-24.webm
Member
|
Were there any changes in this regard that lead to this behaviour? compared to 25. |
Contributor
Author
Yes: #33703 |
Contributor
Author
blizzz
approved these changes
Mar 15, 2023
Contributor
Author
|
/backport to stable26 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Member
|
/backport to stable26 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It only makes sense to send a pagination control with size 0 with a
cookie to abandon a paged search.
Checklist