fix: Avoid log spam on 404 routes not using GET#37026
Merged
nickvergessen merged 1 commit intomasterfrom Mar 7, 2023
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
come-nc
approved these changes
Mar 3, 2023
Member
Author
|
/backport to stable26 |
nickvergessen
approved these changes
Mar 7, 2023
Member
nickvergessen
left a comment
There was a problem hiding this comment.
I had this fixed locally as well already. seems I just didn't send it yet :-X
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid error logging in cases where a 404 page is rendered on non-GET requests. Ideally we would have the /error/404 route handle all http methods but this would mean we need to add each individually to the routes file as there is no combined way in the symphony router symfony/symfony#45218
Checklist