fix: Only try to access params for relevant routes

[juliusknorr]

Summary

server/apps/systemtags/lib/Activity/Provider.php

Lines 85 to 93 in cf8d97c

	if ($this->activityManager->isFormattingFilteredObject()) {
	try {
	return $this->parseShortVersion($event);
	} catch (\InvalidArgumentException $e) {
	// Ignore and simply use the long version...
	}
	}
	return $this->parseLongVersion($event);

could also get called on unrelated requests so we should make sure to not cause problems when trying to get params that don't exist on unrelated requests.

@nickvergessen Do we actually need that separation in the system tags provider to render them differently? My assumption is that this is then based on the activity API request, but feels like an odd place for checking the parameters there.

Fixes random errors like this:

LogicException: "put" can only be accessed once if not application/x-www-form-urlencoded or application/json.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

Do we actually need that separation in the system tags provider to render them differently? My assumption is that this is then based on the activity API request, but feels like an odd place for checking the parameters there.

I think it happens like:

• File is uploaded
• Autotagging happens
• Triggers an activity entry
• Any user with the activity opted in for getting activities as push notifications
• That means we render the activity
• Parameters are checked

But also this is not a unique problem here. I wonder if IRequest should be save guarded instead?

[juliusknorr]

I've also wondered if

server/lib/private/AppFramework/Http/Request.php

Line 401 in f5c361c

throw new \LogicException(

should actually throw or just be a debug log. It could just return existing parameters from

server/lib/private/AppFramework/Http/Request.php

Line 139 in f5c361c

$this->items['parameters'] = array_merge(

[juliusknorr]

Pushed a generic approach to #36525