fix the login log entry

[szaimen]

fix #23063

[ChristophWurst]

👍

[blizzz]

Just to be on the safe side: this does not conflict with any passwordless login things?

[szaimen]

Just to be on the safe side: this does not conflict with any passwordless login things?

Why should it? Isnt that using a different endpoint? And if so ir should have failed before?

Also since @ChristophWurst already approved I think it should be fine.

[kesselb]

The fix looks wrong to me.

{
   "method":"POST",
   "url":"/login",
   "message":"Argument 1 passed to OC\\Core\\Controller\\LoginController::tryLogin() must be of the type string, null given, called in /var/www/html/lib/private/AppFramework/Http/Dispatcher.php on line 217",
}

The error is triggered by post request but the form data / inputs for username and password are missing.
A default value for username and password will not address the actual issue.

I believe the actual issue is something like #36286.

[szaimen]

@kesselb I rather think this is someone trying to log in without providing a username. However I don't think that this should be logged as error. So changing the level of the error would be fine by me as well but is this even possible technically?

[kesselb]

Username and Password are required fields. You cannot submit the login form without them.

This patch is a workaround to hide another error 🙈

[szaimen]

This patch is a workaround to hide another error 🙈

Since you seem to be sure about this I'm going to close this attempt.

[szaimen]

Too bad. I hoped to get rid of these logs that spam the logs on my test instance:

[szaimen]

I mean this was fine to log as loglevel warning or info but it seems rather overkill as error...

[kesselb]

Mind to have a look at the webserver's access log? Maybe it tells us more about the origin of the request.

[szaimen]

The webservers access log is not kept on my test server so I cannot tell you anything except it seems to be always the same external ip-address (not mine) and a Windows device likely with chrome browser: remoteAddr":"137.184.182.xxx", "user":"--","app":"index","method":"POST","url":"/login","message":"OC\\Core\\Controller\\LoginController::tryLogin(): Argument #1 ($user) must be of type string, null given, called in /var/www/html/lib/private/AppFramework/Http/Dispatcher.php on line 225 in file '/var/www/html/core/Controller/LoginController.php' line 298","userAgent":"Mozilla/5.0 (Windows NT 6.4; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2225.0 Safari/537.36"

[kesselb]

👍

[szaimen]

Thanks Daniel!

[szaimen]

Backport to stable25 here: #36672