Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
ChristophWurst
approved these changes
Jan 26, 2023
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Might also make sense to move generated css files to /dist and leave core/css for source files only
Member
Won't work with our |
artonge
approved these changes
Jan 26, 2023
Member
yet ;) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark compiled CSS as binary in the
.gitattributesfile as viewing the textual diff of a single long line in e.g. https://github.com/nextcloud/server/blob/4caa90dfb643aea958b10d0741a8f21be5e18f39/core/css/server.css and https://github.com/nextcloud/server/blob/4caa90dfb643aea958b10d0741a8f21be5e18f39/core/css/server.css.map is not necessary when the source SCSS files e.g. https://github.com/nextcloud/server/blob/4caa90dfb643aea958b10d0741a8f21be5e18f39/core/css/styles.scss are much more readableChecklist