Deprecate and cleanup OC.L10N in favor of @nextcloud/l10n #36287
Merged
juliusknorr merged 4 commits intomasterfrom Feb 20, 2023
Merged
Deprecate and cleanup OC.L10N in favor of @nextcloud/l10n #36287juliusknorr merged 4 commits intomasterfrom
OC.L10N in favor of @nextcloud/l10n #36287juliusknorr merged 4 commits intomasterfrom
Conversation
Pytal
approved these changes
Jan 23, 2023
skjnldsv
reviewed
Jan 24, 2023
core/src/OC/l10n.js
Outdated
Comment on lines
71
to
73
| * @deprecated 26.0.0 use `_unregister` from https://www.npmjs.com/package/@nextcloud/l10n | ||
| */ | ||
| _unregister: unregisterAppTranslations, | ||
| _unregister, |
Member
There was a problem hiding this comment.
is it a private method? Then it should not be exposed or it should be made public?
Contributor
Author
There was a problem hiding this comment.
This is currently only used in CI tests, but I do not see a reason why this function should not be on the public API.
Maybe we should change this on the @nextcloud/l10n package.
But for this PR I wanted to keep the changes small and do not introduce a breaking API change.
skjnldsv
approved these changes
Jan 24, 2023
a9a2799 to
1705765
Compare
Contributor
Author
|
/compile |
Contributor
Author
|
Rebased onto current master |
Contributor
Author
|
Blocked by nextcloud-libraries/nextcloud-l10n#571 (and we need to wait for a new release) |
2437eba to
5a11c08
Compare
Merged
…C app Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
5a11c08 to
ffeabde
Compare
Contributor
Author
|
/compile |
…nextcloud/l10n` Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
…ymore Meaning we can not stub `getLocale` but must override the document attribute instead. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
23fea27 to
c97137e
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Contributor
Author
|
The drone CI failure on the mysql DB tests seem unrelated. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consists of three parts:
OC:OC.addTranslationswas deprecated with NC17 and is not used anymore by any app within the github nextcloud organizationOC.getLocaleandOC.getLanguageas they are provided by@nextcloud/l10nand drop duplicated code@nextcloud/l10n.Checklist
OC.addTranslationsto NC26 upgrade guide documentation#9575 (upgrade guide)