Skip to content

feat(files): Quota in navigation #36002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Jan 18, 2023
Merged

feat(files): Quota in navigation #36002

skjnldsv merged 1 commit into from
Jan 18, 2023

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 4, 2023 •
edited
Loading

Followup #35772

Unlimited With quota
1 2
Warning >80% Full
3 4

Feat

  • Click refreshes the quota
  • Auto-refresh in background
  • Auto-refresh from global files event (deletion, upload, update)
  • Testing

Associated fixes

@skjnldsv skjnldsv self-assigned this Jan 4, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch from 6d4dc16 to e086296 Compare January 4, 2023 18:25
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch from e55eb37 to 1685bfc Compare January 11, 2023 20:03
skjnldsv
skjnldsv commented Jan 11, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch 4 times, most recently from 1c1587e to 2eb8ef9 Compare January 12, 2023 11:19
@skjnldsv skjnldsv marked this pull request as ready for review January 12, 2023 11:30
@skjnldsv skjnldsv requested review from a team, Pytal, artonge and szaimen and removed request for a team January 12, 2023 11:30
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 12, 2023
@skjnldsv skjnldsv requested a review from PVince81 January 12, 2023 11:30
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Jan 12, 2023
artonge
artonge reviewed Jan 12, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch from 2eb8ef9 to 2ec1dcf Compare January 12, 2023 12:58
@skjnldsv skjnldsv requested a review from artonge January 12, 2023 12:59
come-nc
come-nc reviewed Jan 12, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch from 2ec1dcf to 27de18e Compare January 12, 2023 16:26
@skjnldsv skjnldsv requested a review from come-nc January 12, 2023 16:27
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 12, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch from 27de18e to 03282dc Compare January 12, 2023 18:35
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 12, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch from 03282dc to 82111c7 Compare January 13, 2023 06:31
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 13, 2023

Failures unrelated

come-nc
come-nc approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PHP only, fine apart from nitpick and an identation weirdness in the test.

@skjnldsv
feat(files): Quota in navigation
b9906fb 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch from 82111c7 to b9906fb Compare January 17, 2023 17:31
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 17, 2023
@skjnldsv skjnldsv merged commit 1a0f9b5 into master Jan 18, 2023
@skjnldsv skjnldsv deleted the feat/files2vue-quota branch January 18, 2023 07:05
@nickvergessen nickvergessen mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files

Projects

Files to vue
Status: Done

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @artonge @come-nc