fix typehints for generated migrations#34487
Merged
CarlSchwan merged 1 commit intomasterfrom Oct 10, 2022
Merged
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
nickvergessen
approved these changes
Oct 9, 2022
skjnldsv
approved these changes
Oct 9, 2022
ChristophWurst
approved these changes
Oct 10, 2022
Member
Author
|
who do I need to bribe to restart some of the drone tests? |
Member
|
Ci failure is unrelated |
Member
|
Commented on the wrong PR: |
| * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper` | ||
| * @param array $options | ||
| * @param Closure(): ISchemaWrapper $schemaClosure | ||
| g * @param array $options |
Member
There was a problem hiding this comment.
we still generate this for every new migration
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://psalm.dev/r/354eb7817b
This way there is no need to manually typehint each call to $schemaClosure in the calls.