Conversation
Member
Author
|
wait, now I realize that we only wanted to remove collabora code from the list, assuming that it would be installed anyway. but now I renamed it from the code, so it won't be installed... I'll bring it back on the backend only... |
Removed collabora code. Added description for richdocuments as the name will be "Nextcloud Office" pulled from the app store. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
8c7f347 to
71eab82
Compare
Member
Author
|
okay, I pushed again, now, as per requirements: richdocumentscode doesn't appear in the visible list but will still be installed |
Member
Author
|
and, I added a name override for Collabora Office so that it always appears as "Nextcloud Office" |
szaimen
reviewed
Sep 14, 2022
Contributor
|
BTW @PVince81 didn't we also put recognize into recommended apps? |
Pytal
approved these changes
Sep 14, 2022
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed collabora code.
Added description for richdocuments as the name will be "Nextcloud Office" pulled from the app store.
Note: currently it still says "Collabora Online" and the text will change as soon as the app store name changes to "Nextcloud Office" as well in the next app release: https://apps.nextcloud.com/apps/richdocuments